Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Redact sensitive URL parameters from audit logging #4070

Merged
merged 1 commit into from
Feb 23, 2024
Merged

[Backport 2.x] Redact sensitive URL parameters from audit logging #4070

merged 1 commit into from
Feb 23, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e40efdc from #4067.

@github-actions @peternied
Redact sensitive URL parameters from audit logging (#4067)
4322b73 
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Peter Nied <[email protected]>
(cherry picked from commit e40efdc)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@codecov Codecov
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

Attention: Patch coverage is 74.19355% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 65.73%. Comparing base (51e996d) to head (4322b73).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.x    #4070      +/-   ##
==========================================
- Coverage   65.75%   65.73%   -0.03%     
==========================================
  Files         297      297              
  Lines       21115    21143      +28     
  Branches     3455     3459       +4     
==========================================
+ Hits        13884    13898      +14     
- Misses       5504     5513       +9     
- Partials     1727     1732       +5
Files Coverage Δ
...earch/security/auditlog/impl/AbstractAuditLog.java 76.62% <100.00%> (+0.42%) ⬆️
...rg/opensearch/security/auth/HTTPAuthenticator.java 100.00% <100.00%> (ø)
...g/opensearch/security/rest/SecurityInfoAction.java 51.85% <100.00%> (ø)
...pensearch/security/auditlog/impl/AuditMessage.java 74.76% <75.00%> (-0.24%) ⬇️
...mazon/dlic/auth/http/jwt/HTTPJwtAuthenticator.java 72.11% <0.00%> (-2.15%) ⬇️
...ensearch/security/auditlog/config/AuditConfig.java 97.12% <70.00%> (-2.11%) ⬇️

... and 2 files with indirect coverage changes

@cwperks cwperks merged commit c95d37c into 2.x Feb 23, 2024
88 checks passed
@cwperks cwperks deleted the backport/backport-4067-to-2.x branch February 23, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cwperks cwperks cwperks approved these changes

@cliu123 cliu123 Awaiting requested review from cliu123

@DarshitChanpura DarshitChanpura Awaiting requested review from DarshitChanpura DarshitChanpura is a code owner

@davidlago davidlago Awaiting requested review from davidlago

@peternied peternied Awaiting requested review from peternied peternied is a code owner

@RyanL1997 RyanL1997 Awaiting requested review from RyanL1997 RyanL1997 is a code owner

@stephen-crawford stephen-crawford Awaiting requested review from stephen-crawford

@reta reta Awaiting requested review from reta reta is a code owner

@willyborankin willyborankin Awaiting requested review from willyborankin willyborankin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwperks